Ivojedi

  • More
  • SWGEMU-781
  • submitted for moderator approval
  • More
  • SWGEMU-777
  • submitted for moderator approval
  • More
  • SWGEMU-770
  • submitted for moderator approval
  • More
  • SWGEMU-769
  • submitted for moderator approval
  • More
  • SWGEMU-758
  • submitted for moderator approval
I created the function to do as you asked and call it each place in the task that I'm changing the milkState. I also renamed the failure variable to success and inverted it's states and checks as r...

I created the function to do as you asked and call it each place in the task that I'm changing the milkState. I also renamed the failure variable to success and inverted it's states and checks as requested. The changes can be found in the 4th patch.

I believe that I've done each thing you requested. The 3rd patch has the changes.

I believe that I've done each thing you requested. The 3rd patch has the changes.

  • More
  • SWGEMU-742
  • submitted for moderator approval
  • More
  • SWGEMU-746
  • submitted for moderator approval
You really need to do more research on what creatures should have lairs before adding them. Not every creature/npc type spawned with a lair back on live. A couple examples from this patch are the a...

You really need to do more research on what creatures should have lairs before adding them. Not every creature/npc type spawned with a lair back on live. A couple examples from this patch are the adolescent and adult pygmy tortons. Neither of them ever spawned with lairs, nor spawned at all except within the pygmy torton cave POI.

There are many other lairs in your patches the last couple of days that are not appropriate. For starters, I would avoid creating npc lairs all together for the time being. The only times npcs ever spawned with a lair on live was when they were mission targets. Please only populate lairs that you have good evidence/recollection of existing during pre-cu. This will make it easier on the reviewers and save yourself from wasting effort.

  • More
  • SWGEMU-716
  • submitted for moderator approval
Correcting the display on a factory's list of ingredients SUIListBox was a simple matter of adding a space here.

Correcting the display on a factory's list of ingredients SUIListBox was a simple matter of adding a space here.

This is where the formatting for the display in the datapad happens. No matter what I tried, the name string for a looted component did not display properly if I concatenated anything after it. I a...

This is where the formatting for the display in the datapad happens. No matter what I tried, the name string for a looted component did not display properly if I concatenated anything after it. I also tried switching it to use a StringBuffer, but that seemed to make no difference. Moving the serial number to be part of the second parameter passed allowed me to have everything display properly, if not in exactly the correct order.

After trying multiple different formats, the one I've included in this patch seemed the most readable to me, though not exactly how it should be. If anyone has a better idea of how to format the display, I'm certainly open to suggestions.

  • More
  • SWGEMU-682
  • submitted for moderator approval
  • More
  • SWGEMU-681
  • submitted for moderator approval
  • More
  • SWGEMU-680
  • submitted for moderator approval
  • More
  • SWGEMU-677
  • submitted for moderator approval
I went ahead and reworked this patch to add the combatSpam to CreatureAttackData and to get it from there inside CombatManager. It's uploaded in the 4th patch file.

I went ahead and reworked this patch to add the combatSpam to CreatureAttackData and to get it from there inside CombatManager. It's uploaded in the 4th patch file.

I think I see what you are saying about the CreatureAttackData. Would you prefer it if I went back and added a combatSpam member to CreatureAttackData? It could get the spam from the command upon i...

I think I see what you are saying about the CreatureAttackData. Would you prefer it if I went back and added a combatSpam member to CreatureAttackData? It could get the spam from the command upon initialization but be overriden via the arguments in the case of grenade. I could then just pull the combatSpam directly from CreatureAttackData in CombatManager. Seems like a cleaner solution than what I added now that I know how to do it. I'm assuming that I would format the argument similar to how it is in the scatterhit, etc. commands that you tweaked earlier.

I've uploaded a third revision with the required changes.

I've uploaded a third revision with the required changes.

Gotcha. Rather than returning I'll invert the checks and nest them with the assignment inside the second check.

Gotcha. Rather than returning I'll invert the checks and nest them with the assignment inside the second check.