SWGEMU-650 Grenade Implementation - Part 6 (final)

Details
Objectives
General Comments 5 (0)

grenade_final.patch (3 months and 8 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone 0 (0)
  - managers/combat 0 (0)
    - CombatManager.cpp 2 (0) x
    - CombatManager.h 0 (0) x
  - objects/creature/commands 0 (0)
    - ThrowGrenadeCommand.h 5 (0) x
grenade_final2.patch (3 months and 6 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone 0 (0)
  - managers/combat 0 (0)
    - CombatManager.cpp 2 (0) x
    - CombatManager.h 0 (0) x
  - objects/creature/commands 0 (0)
    - ThrowGrenadeCommand.h 0 (0) x
grenade_final3.patch (3 months and 6 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone 0 (0)
  - managers/combat 0 (0)
    - CombatManager.cpp 0 (0) x
    - CombatManager.h 0 (0) x
  - objects/creature/commands 0 (0)
    - ThrowGrenadeCommand.h 2 (0) x
grenade_final4.patch (3 months and 6 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone 0 (0)
  - managers/combat 0 (0)
    - CombatManager.cpp 0 (0) x
    - CombatManager.h 0 (0) x
    - CreatureAttackData.cpp 0 (0) x
    - CreatureAttackData.h 0 (0) x
  - objects/creature/commands 0 (0)
    - ThrowGrenadeCommand.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ivojedi	Author	1h 29m	8	I went ahead and reworked this patch to add the combatSpa...
TheAnswer	Moderator	10m	7	Yes this is better.
Itac	Reviewer - 0% complete
Loshult	Reviewer - 71% complete	25m	1	We have started to use Gerrit for reviews instead of Fish...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 71% complete	4m
Total		2h 8m	16

Files: 14
Patches:
- grenade_final.patch: (anchored to swgemu : core3/branches/unstable/ )
- grenade_final2.patch: (anchored to swgemu : core3/branches/unstable/ )
- grenade_final3.patch: (anchored to swgemu : core3/branches/unstable/ )
- grenade_final4.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

[Added] Throw grenade command, grenades should be fully functional now
[Added] Checks for range and los for grenades to CombatManager
[Added] Weapon argument to a couple more methods in CombatManager that were missed in rev. 6481
[Removed] Some duplicate, unused methods from CombatManager
[Added] Missing break in CombatManager

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

15 Feb

Ivojedi says:

I've updated the patch. I removed the improper assignment of the combatSpam to the command's member. Instead, I put checks in CombatManager for empty combatSpam strings and, where empty, use the combatSpam member from the weapon's template.

#permalink

15 Feb

Ivojedi says:

I've uploaded a third revision with the required changes.

#permalink

15 Feb

Ivojedi says:

I went ahead and reworked this patch to add the combatSpam to CreatureAttackData and to get it from there inside CombatManager. It's uploaded in the 4th patch file.

#permalink

16 Feb

TheAnswer says:

Yes this is better.

#permalink

17 Mar

Loshult says:

We have started to use Gerrit for reviews instead of Fishey. Please follow the instructions on the following page: https://www.assembla.com/spaces/swgemu/wiki/Git_Gerrit_and_Jenkins and push your patch to Gerrit instead.

#permalink

/workspace/.../combat/CombatManager.cpp Changed 2 (0) #permalink
Click to load diff

/workspace/.../combat/CombatManager.h Changed #permalink
Click to load diff

/workspace/.../commands/ThrowGrenadeCommand.h Changed 5 (0) #permalink
Click to load diff

/workspace/.../combat/CombatManager.cpp Changed 2 (0) #permalink
Click to load diff

/workspace/.../combat/CombatManager.h Changed #permalink
Click to load diff

/workspace/.../commands/ThrowGrenadeCommand.h Changed #permalink
Click to load diff

/workspace/.../combat/CombatManager.cpp Changed #permalink
Click to load diff

/workspace/.../combat/CombatManager.h Changed #permalink
Click to load diff

/workspace/.../commands/ThrowGrenadeCommand.h Changed 2 (0) #permalink
Click to load diff

/workspace/.../combat/CombatManager.cpp Changed #permalink
Click to load diff

/workspace/.../combat/CombatManager.h Changed #permalink
Click to load diff

/workspace/.../combat/CreatureAttackData.cpp Changed #permalink
Click to load diff

/workspace/.../combat/CreatureAttackData.h Changed #permalink
Click to load diff

/workspace/.../commands/ThrowGrenadeCommand.h Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-650

Grenade Implementation - Part 6 (final)

Abandoned on 19 Mar

Author

Moderator

Reviewers

SWGEMU-650 16 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Ivojedi says:

Ivojedi says:

Ivojedi says:

TheAnswer says:

Loshult says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-650

Grenade Implementation - Part 6 (final)

Abandoned on 19 Mar

Author

Moderator

Reviewers

SWGEMU-650 16 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Ivojedi says:

Ivojedi says:

Ivojedi says:

TheAnswer says:

Loshult says:

Create Issue

Log time against