SWGEMU-580 Grenade Implementation Part 3

Details
Objectives
Summary
General Comments 0 (0)

refactor_getCommandDuration.patch (3 months and 12 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone 0 (0)
  - managers/objectcontroller 0 (0)
    - ObjectControllerImplementation.cpp 0 (0) x
  - objects/creature/commands 0 (0)
    - ChannelForceCommand.h 0 (0) x
    - CombatQueueCommand.h 0 (0) x
    - DrainForceCommand.h 0 (0) x
    - FlourishCommand.h 0 (0) x
    - ForcePowersQueueCommand.h 0 (0) x
    - HealActionSelf1Command.h 0 (0) x
    - HealActionSelf2Command.h 0 (0) x
    - HealActionWoundSelf1Command.h 0 (0) x
    - HealActionWoundSelf2Command.h 0 (0) x
    - HealAllSelf1Command.h 0 (0) x
    - HealAllSelf2Command.h 0 (0) x
    - HealBattleFatigueSelf1Command.h 0 (0) x
    - HealBattleFatigueSelf2Command.h 0 (0) x
    - HealHealthSelf1Command.h 0 (0) x
    - HealHealthSelf2Command.h 0 (0) x
    - HealHealthWoundSelf1Command.h 0 (0) x
    - HealHealthWoundSelf2Command.h 0 (0) x
    - HealMindSelf1Command.h 0 (0) x
    - HealMindSelf2Command.h 0 (0) x
    - HealMindWoundSelf1Command.h 0 (0) x
    - HealMindWoundSelf2Command.h 0 (0) x
    - HealStatesSelfCommand.h 0 (0) x
    - HeavyWeaponQueueCommand.h 0 (0) x
    - QueueCommand.h 0 (0) x
    - TransferForceCommand.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Ivojedi	Author	5m
TheAnswer	Moderator	0m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	1m
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete
Total		7m	0

Files: 26
Patches:
- refactor_getCommandDuration.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

[Changed] refactored getCommandDuration method in QueueCommand to pass the command arguments as an additional parameter

This is needed to allow the throwGrenade command to get the proper speed off the thrown weapon which is not the equipped weapon. I'll modify the throwGrenade command in a later patch.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/workspace/.../objectcontroller/ObjectControllerImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../commands/ChannelForceCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/CombatQueueCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/DrainForceCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/FlourishCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/ForcePowersQueueCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/HealActionSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealActionSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealActionWoundSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealActionWoundSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealAllSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealAllSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealBattleFatigueSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealBattleFatigueSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealHealthSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealHealthSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealHealthWoundSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealHealthWoundSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealMindSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealMindSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealMindWoundSelf1Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealMindWoundSelf2Command.h Changed #permalink
Click to load diff

/workspace/.../commands/HealStatesSelfCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/HeavyWeaponQueueCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/QueueCommand.h Changed #permalink
Click to load diff

/workspace/.../commands/TransferForceCommand.h Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-580

Grenade Implementation Part 3

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-580 0 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-580

Grenade Implementation Part 3

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-580 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against