SWGEMU-578 Grenade Implementation Part 1

Details
Objectives
Summary
General Comments 0 (0)

grenade_luas2.patch (3 months and 14 days ago) 0 (0)
- workspace/MMOCoreORB 0 (0)
  - bin/scripts 0 (0)
    - commands 0 (0)
      - throwGrenade.lua 0 (0) x
    - object/weapon/ranged/grenade 0 (0)
      - grenade_cryoban.lua 0 (0) x
      - grenade_fragmentation.lua 0 (0) x
      - grenade_fragmentation_light.lua 0 (0) x
      - grenade_glop.lua 0 (0) x
      - grenade_imperial_detonator.lua 0 (0) x
      - grenade_proton.lua 0 (0) x
      - grenade_thermal_detonator.lua 0 (0) x
  - src/server/zone/objects/creature/commands 0 (0)
    - ThrowGrenadeCommand.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Ivojedi	Author	10m
TheAnswer	Moderator	0m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	2m
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete	1m
Total		13m	0

Files: 9
Patches:
- grenade_luas.patch: (anchored to : / )
- grenade_luas2.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

[Added] .lua files needed as part of implementing grenades

I uploaded a second patch to change ThrowGrenadeCommand.h from inheriting QueueCommand to inheriting CombatQueueCommand. This eliminates a few unknown variable errors on server start up that were present before, and was a change that needed to happen eventually anyway. The actual implementation of the command will come in a later part.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/workspace/.../commands/throwGrenade.lua Changed #permalink
Click to load diff

/workspace/.../grenade/grenade_cryoban.lua Changed #permalink
Click to load diff

/workspace/.../grenade/grenade_fragmentation.lua Changed #permalink
Click to load diff

/workspace/.../grenade/grenade_fragmentation_light.lua Changed #permalink
Click to load diff

/workspace/.../grenade/grenade_glop.lua Changed #permalink
Click to load diff

/workspace/.../grenade/grenade_imperial_detonator.lua Changed #permalink
Click to load diff

/workspace/.../grenade/grenade_proton.lua Changed #permalink
Click to load diff

/workspace/.../grenade/grenade_thermal_detonator.lua Changed #permalink
Click to load diff

/workspace/.../commands/ThrowGrenadeCommand.h Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-578

Grenade Implementation Part 1

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-578 0 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-578

Grenade Implementation Part 1

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-578 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against