SWGEMU-569 NPC lair fix

Details
Objectives
Summary
General Comments 0 (0)

npc_lairs.patch (3 months and 18 days ago) 0 (0)
- workspace/MMOCoreORB-Testing/src/server/zone/templates/mobile 0 (0)
  - LairTemplate.h 2 (0) x
npc_lairs2.patch (3 months and 10 days ago) 0 (0)
- workspace/MMOCoreORB/src/server/zone 0 (0)
  - managers/creature 0 (0)
    - LairObserverImplementation.cpp 2 (0) x
  - templates/mobile 0 (0)
    - LairTemplate.h 1 (0) x
npc_lairs3.patch (3 months and 9 days ago) 0 (0)
- workspace/MMOCoreORB 0 (0)
  - bin/scripts/mobile/lair 0 (0)
    - criminal_base.lua 0 (0) x
    - global_imperial_cadet_camp_imperial_small_theater.lua 0 (0) x
    - global_imperial_cadet_senior_camp_imperial_small_theater.lua 0 (0) x
    - global_imperial_cadet_squadleader_camp_imperial_small_theater.lua 0 (0) x
    - global_rebel_patrol_camp_rebel_small_theater.lua 0 (0) x
    - global_rebel_resistance_anarchist_camp_rebel_small_theater.lua 0 (0) x
    - global_rebel_resistance_dissident_camp_rebel_small_theater.lua 0 (0) x
    - global_stormtrooper.lua 0 (0) x
    - imperial.lua 0 (0) x
    - imperial_banner.lua 0 (0) x
    - lair.lua 0 (0) x
    - rebel.lua 0 (0) x
    - rebel_npc.lua 0 (0) x
  - src/server/zone 0 (0)
    - managers/creature 0 (0)
      - LairObserverImplementation.cpp 0 (0) x
    - templates/mobile 0 (0)
      - LairTemplate.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ivojedi	Author	35m	2	I've made both changes you suggested. The third patch is ...
TheAnswer	Moderator
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	15m	3	Remove negation and check for equality with LairTemplate:...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 5% complete	1m
Total		51m	5

Files: 18
Patches:
- npc_lairs.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- npc_lairs2.patch: (anchored to swgemu : core3/branches/unstable/ )
- npc_lairs3.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

[Fixed] NPC lairs (missions) to no longer spawn additional mobs when the lair is attacked. Increased the number of initial spawns slightly at NPC lairs.

In order to accomplish this I added a new member to LairTemplate.h in order to distinguish between a creature lair and an NPC lair. I figured this was a better solution than looking at the mobiles attached to the lair because there can be multiple mobiles and there can even be a mix of creatures and NPCs attached to a lair. The spawner tool will probably need to be updated to allow the lairType to be set when generating a lair.

I also added a check to the observer that should have been added with my last lair patch to prevent a lair from spawning mobs beyond the spawnLimit.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/workspace/.../mobile/LairTemplate.h Changed 2 (0) #permalink
Click to load diff

/workspace/.../creature/LairObserverImplementation.cpp Changed 2 (0) #permalink
Click to load diff

/workspace/.../mobile/LairTemplate.h Changed 1 (0) #permalink
Click to load diff

/workspace/.../lair/criminal_base.lua Changed #permalink
Click to load diff

/workspace/.../lair/global_imperial_cadet_camp_imperial_small_theater.lua Changed #permalink
Click to load diff

/workspace/.../lair/global_imperial_cadet_senior_camp_imperial_small_theater.lua Changed #permalink
Click to load diff

/workspace/.../lair/global_imperial_cadet_squadleader_camp_imperial_small_theater.lua Changed #permalink
Click to load diff

/workspace/.../lair/global_rebel_patrol_camp_rebel_small_theater.lua Changed #permalink
Click to load diff

/workspace/.../lair/global_rebel_resistance_anarchist_camp_rebel_small_theater.lua Changed #permalink
Click to load diff

/workspace/.../lair/global_rebel_resistance_dissident_camp_rebel_small_theater.lua Changed #permalink
Click to load diff

/workspace/.../lair/global_stormtrooper.lua Changed #permalink
Click to load diff

/workspace/MMOCoreORB/.../lair/imperial.lua Changed #permalink
Click to load diff

/workspace/.../lair/imperial_banner.lua Changed #permalink
Click to load diff

/workspace/MMOCoreORB/.../mobile/lair/lair.lua Changed #permalink
Click to load diff

/workspace/MMOCoreORB/.../lair/rebel.lua Changed #permalink
Click to load diff

/workspace/MMOCoreORB/.../lair/rebel_npc.lua Changed #permalink
Click to load diff

/workspace/.../creature/LairObserverImplementation.cpp Changed #permalink
Click to load diff

/workspace/.../mobile/LairTemplate.h Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-569

NPC lair fix

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-569 5 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-569

NPC lair fix

Closed on 07 Feb

Author

Moderator

Reviewers

SWGEMU-569 5 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Create Issue

Log time against