SWGEMU-557 Stun State and Primary Defense Buffs

Stun State and Primary Defense Buffs

Details
Objectives
General Comments 1 (0)

combat2.patch (3 months and 27 days ago) 0 (0)
- MMOCoreORB/src/server/zone 0 (0)
  - managers/combat 0 (0)
    - CombatManager.cpp 6 (0) x
    - CombatManager.h 0 (0) x
  - objects/creature 0 (0)
    - CreatureObjectImplementation.cpp 2 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Yog-Sothoth	Author	1h 6m	4	Shouldn't they be hard-coded anyway? Since they are the o...
TheAnswer	Moderator
Itac	Reviewer - 0% complete
Loshult	Reviewer - 66% complete	2m	1	We have started to use Gerrit for reviews instead of Fish...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 100% complete	14m	4	Because you are hard-coding individual buffs into combat ...
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete
bluree	Reviewer - 66% complete	4m
Total		1h 25m	9

Files: 3
Patches:
- combat2.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

As requested, here is the individual patch.

Changes:

Stun State penalty is applied before the Primary Defense hardcap.
Stun State penalty will no longer be ignored by Creatures/NPCs.
Foods and Squad Leader bonus will be applied after the hardcap.

NOTE: Added an array of constants for buffs that should go above the hard cap, as requested by dannuic.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

17 Mar

Loshult says:

We have started to use Gerrit for reviews instead of Fishey. Please follow the instructions on the following page: https://www.assembla.com/spaces/swgemu/wiki/Git_Gerrit_and_Jenkins and push your patch to Gerrit instead.

#permalink

/MMOCoreORB/src/.../combat/CombatManager.cpp Changed 6 (0) #permalink
Click to load diff

/MMOCoreORB/src/.../combat/CombatManager.h Changed #permalink
Click to load diff

/MMOCoreORB/.../creature/CreatureObjectImplementation.cpp Changed 2 (0) #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-557

Stun State and Primary Defense Buffs

Under Review for 3 months (due 3 months ago)

Author

Moderator

Reviewers

SWGEMU-557 9 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Loshult says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-557

Stun State and Primary Defense Buffs

Under Review for 3 months (due 3 months ago)

Author

Moderator

Reviewers

SWGEMU-557 9 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Loshult says:

Create Issue

Log time against