SWGEMU-553 Combat-related fixes

Details
Objectives
Summary
General Comments 9 (0)

patch1.patch (3 months and 23 days ago) 0 (0)
- MMOCoreORB 0 (0)
  - bin/scripts/object/tangible/food/crafted 0 (0)
    - dish_vegeparsine.lua 0 (0) x
    - drink_elshandruu_pica_thundercloud.lua 0 (0) x
  - src/server/zone 0 (0)
    - managers/combat 0 (0)
      - CombatManager.cpp 42 (0) x
    - objects 0 (0)
      - creature 0 (0)
        
        commands 0 (0)
        
        RallyCommand.h 0 (0) x
        
        variables 0 (0)
        
        CreatureAttackMap.h 6 (0) x
        
        CreatureObject.idl 0 (0) x
        
        CreatureObjectImplementation.cpp 5 (0) x
      - group 0 (0)
        
        GroupObjectImplementation.cpp 8 (0) x
      - tangible/consumable 0 (0)
        
        ConsumableImplementation.cpp 4 (0) x
attackchance.patch (3 months and 22 days ago) 0 (0)
- MMOCoreORB/src/server/zone 0 (0)
  - objects/creature/variables 0 (0)
    - CreatureAttackMap.h 2 (0) x
  - templates/mobile 0 (0)
    - CreatureTemplate.cpp 0 (0) x
attackchance2.patch (3 months and 22 days ago) 0 (0)
- MMOCoreORB/src/server/zone/objects/creature 0 (0)
  - variables 0 (0)
    - CreatureAttackMap.h 0 (0) x
  - AiAgentImplementation.cpp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Yog-Sothoth	Author	3h 50m	31	Of course. Although I won't be submitting any new patches...
TheAnswer	Moderator	20m	8	If its not updating the skill sheet with the modifier, th...
Itac	Reviewer - 0% complete
Loshult	Reviewer - 46% complete	12m	2	Have you everything from this patch saved so that this on...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 69% complete	45m	33	I know it doesn't seem right, that's why I double checked...
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 61% complete	8m
bluree	Reviewer - 69% complete	15m
Valkyra	Reviewer - 100% complete	11m	2	Defense Acuity might not be negated, but "saber_block" sh...
Total		5h 41m	76

Files: 13
Patches:
- patch1.patch: (anchored to swgemu : core3/branches/unstable/ )
- attackchance.patch: (anchored to swgemu : core3/branches/unstable/ )
- attackchance2.patch: (anchored to swgemu : core3/branches/unstable/ )

#permalink

Objectives

Fixes addressed by this patch:

Missing a combat action will no longer apply States and DoTs.
Blind State penalty will now be accounted for when calculating overall bonus accuracy.
Primary defenses bonus from foods and Squad Leader will be applied after the hard cap.
Stun State penalty will now be applied before hard capping primary defenses.
NPCs and Creatures will now be affected by Stun State.
Defensive Acuity will no longer be negated by Intimidate.
Defensive Acuity will no longer return HIT, instead of COUNTER.
Correct damage reductions for Intimidate (33%) and Stun State (15%) are now properly applied to the calculated damage.

NPCs will no longer spam Force Powers Attacks. For each new attack a NPC makes, there will be:

25% chance to add Force Lightning, Mind Blast and Force Throw to the available attack pool.
20% chance to add Force Knockdown and Force Intimidate to the available attack pool.
15% chance to add Force Weaken to the available attack pool.
5% chance to add Force Choke to the available attack pool.

*NOTE: Temporary workaround, should be scrapped in favor of a Lua Object Field once the AI gets developed further.

#permalink

Summary

Patch continued in other smaller reviews.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

25 Jan

TheAnswer says:

Please add your sources for all the combat manager changes.

#permalink

25 Jan

dannuic says:

Those temp fixes can be implemented now, attack pools are in the luas.

#permalink

25 Jan

Yog-Sothoth says:

For Squad Leader bonus:

http://swg.wikia.com/wiki/Group_Melee_Defense_(Skill_Modifier)

And further into SL and Foods:

Primary Defenses
Melee and Ranged Defenses are primary defenses. These defenses work regardless of what weapon a character is wielding. These defenses are rolled against accuracy to see if an attack is successful. Currently these defenses are capped at 125. Only Chef food, Squad Leader and City bonuses can take these over the 125 cap.

http://israfelsswg.blogspot.com/

I know those are unofficial information, but this kinda of information is near impossible (if possible at all) to come through official means. Also that's what people in the forum have been agreeing with,

http://www.swgemu.com/archive/scrapbookv51/data/20080108200838/teras_kasi_2.html

This one points out to Intimidate and Stunned reductions, although Stunned mentions the reduction on the number of attacks, I simply cannot find any specific info on that.
So we can either apply what i've submitted to a 15% reduction to every attack, which in turn is closer to the reduction we had in Live or, I can remove that from the patch.

I cannot for the life of me find any info confirming or disconfirming whether Defensive Acuity was negated by Intimidate.
However, I was a TKM/Fencer in Live and it was known knowledge this was the only secondary defense that could work under Intimidate. This was to emphasizes the fact that TKA was the best defense in the game, while remaining a flawed professions when it comes to dealing damage.
I can remove this from patch aswell, if necessary, but none in the Forums seemed to disagree with this.

The others don't need any source because they are fix to something that was broken and not working as intended.

Yes, attacks pools are in the luas, but you don't have an argument for setting a %¨chance for that attack to be picked,

String com = atk.getStringAt(1).trim();
String arg = atk.getStringAt(2).trim();
attacks->addAttack(com, arg);

Hell, I don't even believe the argument is being used at all in the code currently.

Adding a third argument with that value, is what I meant for the future.
This incurs changing every NPC attack that requires it, that's why I haven't bothered with it until a new core for the AI is implemented.

#permalink

25 Jan

dannuic says:

As for which mods take def over the cap, there are multiple sources that say multiple things. I am pretty sure it was chef food (indirectly!), SL and city bonuses after doing way too much research. I never implemented the SL bonuses properly, but you can't assume that all private mods are post-cap. You need to make a specific set of post-cap mods.

#permalink

25 Jan

Yog-Sothoth says:

I've added a proper and more elegant fix to attack chances for NPCs/Creatures.
Please advise before I proceed to add chances to a few attacks.

#permalink

26 Jan

Loshult says:

I would suggest to split this patch up in several smaller ones. One fix per patch is a recommendation to always use to simplify the review and to ensure quality of the code.

#permalink

26 Jan

Yog-Sothoth says:

Very well, I'll be splitting into several patchs as some of those fixes get properly discussed, like the reduction for Intimidate.

#permalink

05 Feb

Loshult says:

Have you everything from this patch saved so that this one can be closed?

#permalink

05 Feb

Yog-Sothoth says:

Of course. Although I won't be submitting any new patches for the feasible future since I'm taking a break.

#permalink

/MMOCoreORB/.../crafted/dish_vegeparsine.lua Changed #permalink
Click to load diff

/MMOCoreORB/.../crafted/drink_elshandruu_pica_thundercloud.lua Changed #permalink
Click to load diff

/MMOCoreORB/src/.../combat/CombatManager.cpp Changed 42 (0) #permalink
Click to load diff

/MMOCoreORB/src/.../commands/RallyCommand.h Changed #permalink
Click to load diff

/MMOCoreORB/.../variables/CreatureAttackMap.h Changed 6 (0) #permalink
Click to load diff

/MMOCoreORB/.../creature/CreatureObject.idl Changed #permalink
Click to load diff

/MMOCoreORB/.../creature/CreatureObjectImplementation.cpp Changed 5 (0) #permalink
Click to load diff

/MMOCoreORB/.../group/GroupObjectImplementation.cpp Changed 8 (0) #permalink
Click to load diff

/MMOCoreORB/.../consumable/ConsumableImplementation.cpp Changed 4 (0) #permalink
Click to load diff

/MMOCoreORB/.../variables/CreatureAttackMap.h Changed 2 (0) #permalink
Click to load diff

/MMOCoreORB/.../mobile/CreatureTemplate.cpp Changed #permalink
Click to load diff

/MMOCoreORB/.../variables/CreatureAttackMap.h Changed #permalink
Click to load diff

/MMOCoreORB/.../creature/AiAgentImplementation.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-553

Combat-related fixes

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-553 76 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

TheAnswer says:

dannuic says:

Yog-Sothoth says:

dannuic says:

Yog-Sothoth says:

Loshult says:

Yog-Sothoth says:

Loshult says:

Yog-Sothoth says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-553

Combat-related fixes

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-553 76 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

TheAnswer says:

dannuic says:

Yog-Sothoth says:

dannuic says:

Yog-Sothoth says:

Loshult says:

Yog-Sothoth says:

Loshult says:

Yog-Sothoth says:

Create Issue

Log time against