SWGEMU-548 [Fixed] Unit integrity on weapon components to add to condition of crafted weapons

Details
Objectives
Summary
General Comments 5 (0)

weapon_integrity_fix.patch (3 months and 27 days ago) 0 (0)
- workspace/MMOCoreORB-Testing/bin/scripts/object/weapon 0 (0)
  - melee 0 (0)
    - 2h_sword 0 (0)
      - 2h_sword_battleaxe.lua 0 (0) x
      - 2h_sword_blacksun_hack.lua 0 (0) x
      - 2h_sword_cleaver.lua 0 (0) x
      - 2h_sword_katana.lua 0 (0) x
      - 2h_sword_maul.lua 0 (0) x
      - 2h_sword_scythe.lua 0 (0) x
    - axe 0 (0)
      - axe_heavy_duty.lua 0 (0) x
      - axe_vibroaxe.lua 0 (0) x
    - baton 0 (0)
      - baton_gaderiffi.lua 0 (0) x
      - baton_stun.lua 0 (0) x
    - knife 0 (0)
      - knife_dagger.lua 0 (0) x
      - knife_survival.lua 0 (0) x
      - knife_vibroblade.lua 0 (0) x
    - polearm 0 (0)
      - lance_controllerfp.lua 0 (0) x
      - lance_nightsister.lua 0 (0) x
      - lance_staff_metal.lua 0 (0) x
      - lance_staff_wood_s1.lua 0 (0) x
      - lance_staff_wood_s2.lua 0 (0) x
      - lance_vibrolance.lua 0 (0) x
      - polearm_vibro_axe.lua 0 (0) x
    - special 0 (0)
      - vibroknuckler.lua 0 (0) x
    - sword 0 (0)
      - sword_01.lua 0 (0) x
      - sword_02.lua 0 (0) x
      - sword_blade_ryyk.lua 0 (0) x
  - ranged 0 (0)
    - carbine 0 (0)
      - carbine_cdef.lua 0 (0) x
      - carbine_dh17.lua 0 (0) x
      - carbine_dh17_snubnose.lua 0 (0) x
      - carbine_dxr6.lua 0 (0) x
      - carbine_e11.lua 0 (0) x
      - carbine_e11_quest.lua 0 (0) x
      - carbine_ee3.lua 0 (0) x
      - carbine_elite.lua 0 (0) x
      - carbine_laser.lua 0 (0) x
    - pistol 0 (0)
      - pistol_cdef.lua 0 (0) x
      - pistol_d18.lua 0 (0) x
      - pistol_de_10.lua 0 (0) x
      - pistol_dh17.lua 0 (0) x
      - pistol_dl44.lua 0 (0) x
      - pistol_dl44_metal.lua 0 (0) x
      - pistol_dx2.lua 0 (0) x
      - pistol_fwg5.lua 0 (0) x
      - pistol_fwg5_quest.lua 0 (0) x
      - pistol_geonosian_sonic_blaster_loot.lua 0 (0) x
      - pistol_launcher.lua 0 (0) x
      - pistol_power5.lua 0 (0) x
      - pistol_republic_blaster.lua 0 (0) x
      - pistol_republic_blaster_quest.lua 0 (0) x
      - pistol_scatter.lua 0 (0) x
      - pistol_scout_blaster.lua 0 (0) x
      - pistol_srcombat.lua 0 (0) x
      - pistol_striker.lua 0 (0) x
      - pistol_tangle.lua 0 (0) x
    - rifle 0 (0)
      - rifle_acid_beam.lua 0 (0) x
      - rifle_beam.lua 0 (0) x
      - rifle_berserker.lua 0 (0) x
      - rifle_bowcaster.lua 0 (0) x
      - rifle_cdef.lua 0 (0) x
      - rifle_dlt20.lua 0 (0) x
      - rifle_dlt20a.lua 0 (0) x
      - rifle_e11.lua 0 (0) x
      - rifle_flame_thrower.lua 0 (0) x
      - rifle_jawa_ion.lua 0 (0) x
      - rifle_laser.lua 0 (0) x
      - rifle_lightning.lua 0 (0) x
      - rifle_sg82.lua 0 (0) x
      - rifle_spraystick.lua 0 (0) x
      - rifle_t21.lua 0 (0) x
      - rifle_tenloss_dxr6_disruptor_loot.lua 0 (0) x
      - rifle_tusken.lua 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Ivojedi	Author	15m	2	I wasn't aware of the existence of a schematic tool. I ch...
TheAnswer	Moderator
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	6m	3	Yes we have a tool for it, available through dropbox. Cre...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete
Total		21m	5

Files: 69
Patches:
- weapon_integrity_fix.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

[Fixed] Unit integrity on weapon components to add to condition of crafted weapons

These should all be updated in the schematic tool now.

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

26 Jan

Loshult says:

Can you explain the behaviour before and after this patch?

#permalink

26 Jan

Each weapon's hitpoints property has an experimental combine type of 4. A 4 tells it to override all hitpoints properties on components and generate a value based solely upon the resources and experimentation of the final weapon assembly. All values on components are ignored.

Changing the combine type to 1 tells it to add the hitpoints (unit integrity) property from components to the final result in a linear fashion. This allows the unit integrity on components to actually matter as they did on live.

#permalink

26 Jan

Loshult says:

Have you used the schematic tool when updating these? I cannot see that those values are updated there.

#permalink

26 Jan

Ivojedi says:

I wasn't aware of the existence of a schematic tool. I changed those .luas manually. Do I need to use a tool for those types of changes? And where would I find it?

#permalink

26 Jan

Loshult says:

Yes we have a tool for it, available through dropbox. Create a dropbox account and pm me your account info and I'll try to share it with you and give you some crash course on how to use it. Data like this is stored in a database so that we easily can change format of the lua files and regenerate all files if needed.

#permalink

/workspace/.../2h_sword/2h_sword_battleaxe.lua Changed #permalink
Click to load diff

/workspace/.../2h_sword/2h_sword_blacksun_hack.lua Changed #permalink
Click to load diff

/workspace/.../2h_sword/2h_sword_cleaver.lua Changed #permalink
Click to load diff

/workspace/.../2h_sword/2h_sword_katana.lua Changed #permalink
Click to load diff

/workspace/.../2h_sword/2h_sword_maul.lua Changed #permalink
Click to load diff

/workspace/.../2h_sword/2h_sword_scythe.lua Changed #permalink
Click to load diff

/workspace/.../axe/axe_heavy_duty.lua Changed #permalink
Click to load diff

/workspace/.../axe/axe_vibroaxe.lua Changed #permalink
Click to load diff

/workspace/.../baton/baton_gaderiffi.lua Changed #permalink
Click to load diff

/workspace/.../baton/baton_stun.lua Changed #permalink
Click to load diff

/workspace/.../knife/knife_dagger.lua Changed #permalink
Click to load diff

/workspace/.../knife/knife_survival.lua Changed #permalink
Click to load diff

/workspace/.../knife/knife_vibroblade.lua Changed #permalink
Click to load diff

/workspace/.../polearm/lance_controllerfp.lua Changed #permalink
Click to load diff

/workspace/.../polearm/lance_nightsister.lua Changed #permalink
Click to load diff

/workspace/.../polearm/lance_staff_metal.lua Changed #permalink
Click to load diff

/workspace/.../polearm/lance_staff_wood_s1.lua Changed #permalink
Click to load diff

/workspace/.../polearm/lance_staff_wood_s2.lua Changed #permalink
Click to load diff

/workspace/.../polearm/lance_vibrolance.lua Changed #permalink
Click to load diff

/workspace/.../polearm/polearm_vibro_axe.lua Changed #permalink
Click to load diff

/workspace/.../special/vibroknuckler.lua Changed #permalink
Click to load diff

/workspace/.../sword/sword_01.lua Changed #permalink
Click to load diff

/workspace/.../sword/sword_02.lua Changed #permalink
Click to load diff

/workspace/.../sword/sword_blade_ryyk.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_cdef.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_dh17.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_dh17_snubnose.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_dxr6.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_e11.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_e11_quest.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_ee3.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_elite.lua Changed #permalink
Click to load diff

/workspace/.../carbine/carbine_laser.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_cdef.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_d18.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_de_10.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_dh17.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_dl44.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_dl44_metal.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_dx2.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_fwg5.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_fwg5_quest.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_geonosian_sonic_blaster_loot.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_launcher.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_power5.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_republic_blaster.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_republic_blaster_quest.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_scatter.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_scout_blaster.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_srcombat.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_striker.lua Changed #permalink
Click to load diff

/workspace/.../pistol/pistol_tangle.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_acid_beam.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_beam.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_berserker.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_bowcaster.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_cdef.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_dlt20.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_dlt20a.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_e11.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_flame_thrower.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_jawa_ion.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_laser.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_lightning.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_sg82.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_spraystick.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_t21.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_tenloss_dxr6_disruptor_loot.lua Changed #permalink
Click to load diff

/workspace/.../rifle/rifle_tusken.lua Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-548

[Fixed] Unit integrity on weapon components to add to condition of crafted weapons

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-548 5 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Ivojedi says:

Loshult says:

Ivojedi says:

Loshult says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-548

[Fixed] Unit integrity on weapon components to add to condition of crafted weapons

Closed on 05 Feb

Author

Moderator

Reviewers

SWGEMU-548 5 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Ivojedi says:

Loshult says:

Ivojedi says:

Loshult says:

Create Issue

Log time against