SWGEMU-489 {CreatureTemplateManager] ERRORs & other bugs.

Details
Objectives
Summary
General Comments 4 (0)

review489-v5.txt (4 months and 24 days ago) 0 (0)
- bin/scripts 0 (0)
  - managers/spawn_manager 0 (0)
    - corellia.lua 0 (0) x
  - mobile 0 (0)
    - all 0 (0)
      - alert_droideka.lua 0 (0) x
      - serverobjects.lua 0 (0) x
    - corellia 0 (0)
      - cor_swooper.lua 0 (0) x
      - serverobjects.lua 0 (0) x
      - swooper.lua 0 (0) x
    - dathomir 0 (0)
      - bolma_prime.lua 0 (0) x
      - female_kwi.lua 0 (0) x
    - endor 0 (0)
      - gorax.lua 0 (0) x
    - misc 0 (0)
      - contractor.lua 0 (0) x
      - malakili.lua 0 (0) x
      - max_rebo.lua 0 (0) x
      - oola.lua 0 (0) x
      - porcellus.lua 0 (0) x
      - prefect_talmont.lua 0 (0) x
      - r2.lua 0 (0) x
      - r3.lua 0 (0) x
      - r5.lua 0 (0) x
      - salacious_crumb.lua 0 (0) x
      - serverobjects.lua 0 (0) x
      - spacer.lua 0 (0) x
      - sy_snootles.lua 0 (0) x
      - theater_manager.lua 0 (0) x
    - rori 0 (0)
      - serverobjects.lua 0 (0) x
      - tusk_cat.lua 0 (0) x
    - space 0 (0)
      - j1_po.lua 0 (0) x
      - j1_po_space.lua 0 (0) x
      - larek_tatham.lua 0 (0) x
      - logro_elsin.lua 0 (0) x
      - serverobjects.lua 0 (0) x
    - talus 0 (0)
      - berserk_kahmurra.lua 0 (0) x
    - tatooine 0 (0)
      - malakili.lua 0 (0) x
      - mat_rags.lua 0 (0) x
      - oola.lua 0 (0) x
      - pirate.lua 0 (0) x
      - pirate_leader.lua 0 (0) x
      - porcellus.lua 0 (0) x
      - salacious_crumb.lua 0 (0) x
      - scavenger.lua 0 (0) x
      - serverobjects.lua 0 (0) x
      - sy_snootles.lua 0 (0) x
      - thief.lua 0 (0) x
    - thug 0 (0)
      - hunter.lua 0 (0) x
      - pirate_leader.lua 0 (0) x
      - serverobjects.lua 0 (0) x
      - spacer.lua 0 (0) x
    - townsperson 0 (0)
      - hunter.lua 0 (0) x
      - nomad.lua 0 (0) x
      - scavenger.lua 0 (0) x
      - serverobjects.lua 0 (0) x
      - spacer.lua 0 (0) x
    - serverobjects.lua 0 (0) x
  - screenplays/dungeon 0 (0)
    - death_watch_bunker.lua 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
bluree	Author	47m	2	updated with v5
TheAnswer	Moderator
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	12m	1	Please delete the files that you moved so that we don't h...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete	4m	1	Is this missing a couple of serverobjects.lua?
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 0% complete	1m
Total		1h 4m	4

Files: 53
Patches:
- review489-v2.txt: (anchored to : / )
- review489-v3.txt: (anchored to : / )
- review489-v4.txt: (anchored to : / )
- review489-v5.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

[Fixed] Bela Vista Recruiter.
[Fixed] Mandalorian boots crafting.
[Added] Female Kwi, Bolma Prime & Gorax back to game.
[Fixed] Annoying server startup spam regarding duplicate creatures/npcs.
[Fixed] Issue with Berserek kahmurra

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

21 Dec 12

dannuic says:

Is this missing a couple of serverobjects.lua?

#permalink

21 Dec 12

bluree says:

Nope, bolma, kwi and gorax were ingame before but last creature cleanup I did a few months ago removed them somehow.

All other serverobjects I just modified and are in patch

#permalink

26 Dec 12

Loshult says:

Please delete the files that you moved so that we don't have empty files lying around.

#permalink

26 Dec 12

bluree says:

updated with v5

#permalink

/bin/scripts/.../spawn_manager/corellia.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/all/alert_droideka.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/all/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/.../corellia/cor_swooper.lua Added #permalink
Click to load diff

/bin/scripts/.../corellia/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/corellia/swooper.lua Changed #permalink
Click to load diff

/bin/scripts/.../dathomir/bolma_prime.lua Changed #permalink
Click to load diff

/bin/scripts/.../dathomir/female_kwi.lua Added #permalink
Click to load diff

/bin/scripts/mobile/endor/gorax.lua Added #permalink
Click to load diff

/bin/scripts/mobile/misc/contractor.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/malakili.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/max_rebo.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/oola.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/porcellus.lua Changed #permalink
Click to load diff

/bin/scripts/.../misc/prefect_talmont.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/r2.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/r3.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/r5.lua Changed #permalink
Click to load diff

/bin/scripts/.../misc/salacious_crumb.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/spacer.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/misc/sy_snootles.lua Changed #permalink
Click to load diff

/bin/scripts/.../misc/theater_manager.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/rori/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/rori/tusk_cat.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/space/j1_po.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/space/j1_po_space.lua Added #permalink
Click to load diff

/bin/scripts/mobile/space/larek_tatham.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/space/logro_elsin.lua Changed #permalink
Click to load diff

/bin/scripts/.../space/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/.../talus/berserk_kahmurra.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/malakili.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/mat_rags.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/oola.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/pirate.lua Changed #permalink
Click to load diff

/bin/scripts/.../tatooine/pirate_leader.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/porcellus.lua Changed #permalink
Click to load diff

/bin/scripts/.../tatooine/salacious_crumb.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/scavenger.lua Changed #permalink
Click to load diff

/bin/scripts/.../tatooine/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/.../tatooine/sy_snootles.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/tatooine/thief.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/thug/hunter.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/thug/pirate_leader.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/thug/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/thug/spacer.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/townsperson/hunter.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/townsperson/nomad.lua Changed #permalink
Click to load diff

/bin/scripts/.../townsperson/scavenger.lua Changed #permalink
Click to load diff

/bin/scripts/.../townsperson/serverobjects.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/townsperson/spacer.lua Changed #permalink
Click to load diff

/bin/scripts/mobile/serverobjects.lua Changed #permalink
Click to load diff

/bin/.../dungeon/death_watch_bunker.lua Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-489

{CreatureTemplateManager] ERRORs & other bugs.

Closed on 26 Dec 12

Author

Moderator

Reviewers

SWGEMU-489 4 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

dannuic says:

bluree says:

Loshult says:

bluree says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-489

{CreatureTemplateManager] ERRORs & other bugs.

Closed on 26 Dec 12

Author

Moderator

Reviewers

SWGEMU-489 4 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

dannuic says:

bluree says:

Loshult says:

bluree says:

Create Issue

Log time against