SWGEMU-459 (unstable) [fixed] Lair Foraging

Details
Objectives
Summary
General Comments 4 (0)

pasted.patch (5 months and 3 days ago) 0 (0)
- src/server/zone/managers/minigames 0 (0)
  - ForageManagerImplementation.cpp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Galameed	Author	52m	2	I removed the horn because horn is suppose to drop from h...
TheAnswer	Moderator
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	24m	2	Can you summarize what you have done and why?
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
elpete	Reviewer - 100% complete	6m
Total		1h 22m	4

Files: 1
Patches:
- pasted.patch: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

Added check to see if the player is foraging a lair, If the player is foraging a lair it gives proper Lair search message, also removed horn from lair foraging as it should drop off of horned creatures from harvesting (updated 13DEC2012)

#permalink

Summary

Patch committed to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

12 Dec 12

Loshult says:

Please upload this as a patch.
Check you indentation settings and ensure that you indent the added code properly.
Remove any comments in the patch why you added things.

#permalink

14 Dec 12

Galameed says:

Ok fixed it should look correct now

#permalink

14 Dec 12

Loshult says:

Can you summarize what you have done and why?

#permalink

16 Dec 12

Galameed says:

I removed the horn because horn is suppose to drop from horned creatures. I also adjusted the random variable to match that horn is missing. Also I added a check to see if the player it trying to forage from a lair and if they are it sends a proper "You are searching the lair for creatures" instead of "You search the area for goods" message

#permalink

/src/.../minigames/ForageManagerImplementation.cpp Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-459

(unstable) [fixed] Lair Foraging

Closed on 16 Dec 12

Author

Moderator

Reviewers

SWGEMU-459 4 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Galameed says:

Loshult says:

Galameed says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-459

(unstable) [fixed] Lair Foraging

Closed on 16 Dec 12

Author

Moderator

Reviewers

SWGEMU-459 4 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Galameed says:

Loshult says:

Galameed says:

Create Issue

Log time against