SWGEMU-446 Guild and group chat commands

Details
Objectives
Summary
General Comments 4 (0)

patch446-2.txt (5 months and 24 days ago) 0 (0)
- src/server 0 (0)
  - chat 0 (0)
    - ChatManager.cpp 0 (0) x
    - ChatManager.h 0 (0) x
    - ChatManager.idl 0 (0) x
    - ChatManagerImplementation.cpp 0 (0) x
  - zone 0 (0)
    - managers/objectcontroller/command 0 (0)
      - CommandConfigManager.cpp 0 (0) x
    - objects/creature/commands 0 (0)
      - GuildCommand.h 0 (0) x
      - commands.h 0 (0) x
patch446-3.txt (5 months and 5 days ago) 0 (0)
- src/server/zone/objects/creature/commands 0 (0)
  - GCommand.h 0 (0) x
  - GroupSayCommand.h 0 (0) x
  - GsayCommand.h 0 (0) x
  - GtellCommand.h 0 (0) x
  - GuildsayCommand.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Cebot	Author	45m	2	Ok, figured it out. Added another patch that shows those.
TheAnswer	Moderator	0m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	16m	2	Yes it will.
cRush	Reviewer - 0% complete
dannuic	Reviewer - 41% complete	2m
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
Total		1h 3m	4

Files: 12
Patches:
- patch446.txt: (anchored to : / )
- patch446-2.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )
- patch446-3.txt: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

The following commands exist for group and guild chat (http://swg.wikia.com/wiki/Chat_Commands):

/g
/groupChat, aka /group
/groupSay (not working)
/gsay (not working)
/gtell (not working)
/guild, aka /gu (not working)
/guildSay (not working)

The group commands should all do the same thing (and should therefore all use the same class, not individual classes for each command) registered with different strings, and, of course, they should all work like /g and /groupChat do.

This eliminates the need for:

GCommand.h
GroupSayCommand.h
GSayCommand.h
GtellCommand.h
GuildSayCommand.h

The guild commands were not working, so additional methods were added to support broadcasting to the guild room when these slash commands are executed.

#permalink

Summary

Patch submitted to unstable branch.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

13 Dec 12

Loshult says:

Can you complete the patch? If the files stated above isn't needed anymore, remove them.

#permalink

13 Dec 12

Cebot says:

Sorry for my noobishness with SVN, but how do I remove files? If I remove them from my local copy and generate a new patch, will it include that kind of change?

#permalink

14 Dec 12

Loshult says:

Yes it will.

#permalink

17 Dec 12

Cebot says:

Ok, figured it out. Added another patch that shows those.

#permalink

/src/server/chat/ChatManager.cpp Changed #permalink
Click to load diff

/src/server/chat/ChatManager.h Changed #permalink
Click to load diff

/src/server/chat/ChatManager.idl Changed #permalink
Click to load diff

/src/.../chat/ChatManagerImplementation.cpp Changed #permalink
Click to load diff

/src/.../command/CommandConfigManager.cpp Changed #permalink
Click to load diff

/src/server/.../commands/GuildCommand.h Changed #permalink
Click to load diff

/src/server/.../creature/commands/commands.h Changed #permalink
Click to load diff

/src/server/.../creature/commands/GCommand.h Changed #permalink
Click to load diff

/src/server/.../commands/GroupSayCommand.h Changed #permalink
Click to load diff

/src/server/.../commands/GsayCommand.h Changed #permalink
Click to load diff

/src/server/.../commands/GtellCommand.h Changed #permalink
Click to load diff

/src/server/.../commands/GuildsayCommand.h Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-446

Guild and group chat commands

Closed on 17 Dec 12

Author

Moderator

Reviewers

SWGEMU-446 4 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Cebot says:

Loshult says:

Cebot says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-446

Guild and group chat commands

Closed on 17 Dec 12

Author

Moderator

Reviewers

SWGEMU-446 4 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Cebot says:

Loshult says:

Cebot says:

Create Issue

Log time against