SWGEMU-444 AssistCommand.h

Details
Objectives
General Comments 3 (0)

assist.diff (5 months and 23 days ago) 0 (0)
- src/server/zone/objects/creature/commands 0 (0)
  - AssistCommand.h 2 (0) x
assist.diff (5 months and 23 days ago) 0 (0)
- src/server/zone/objects/creature/commands 0 (0)
  - AssistCommand.h 0 (0) x
assist.diff (5 months and 23 days ago) 0 (0)
- src/server/zone/objects/creature/commands 0 (0)
  - AssistCommand.h 1 (0) x
Attachments 0 (0)
- AssistCommand.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
veckon	Author	14m	2	I think the cast here is unnecessary but I saw this in ot...
TheAnswer	Moderator	15m	1	those are unnecessary, left from a code refactoring
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	2h 4m	2	We have started to use Gerrit for reviews instead of Fish...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 100% complete	4m	1	Shouldn't assist get what the other player is targeting? ...
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
Total		2h 38m	6

Files: 4
Patches:
- assist.diff: (anchored to swgemu : core3/trunk/MMOCoreORB/ )
- assist.diff: (anchored to swgemu : core3/trunk/MMOCoreORB/ )
- assist.diff: (anchored to swgemu : core3/trunk/MMOCoreORB/ )

#permalink

Objectives

There are no specific objectives for this review.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

25 Nov 12

veckon says:

Ignore the player->sendSystemMessage()

#permalink

01 Feb

Loshult says:

Can you please update this patch and answer the comments?

#permalink

17 Mar

We have started to use Gerrit for reviews instead of Fishey. Please follow the instructions on the following page: https://www.assembla.com/spaces/swgemu/wiki/Git_Gerrit_and_Jenkins and push your patch to Gerrit instead.

#permalink

/src/server/.../commands/AssistCommand.h Changed 2 (0) #permalink
Click to load diff

/src/server/.../commands/AssistCommand.h Changed #permalink
Click to load diff

/src/server/.../commands/AssistCommand.h Changed 1 (0) #permalink
Click to load diff

/AssistCommand.h Added #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-444

AssistCommand.h

Under Review for 5 months (due 5 months ago)

Author

Moderator

Reviewers

SWGEMU-444 6 (0)

Details

Objectives

Issues Raised From Comments

General Comments

veckon says:

Loshult says:

Loshult says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-444

AssistCommand.h

Under Review for 5 months (due 5 months ago)

Author

Moderator

Reviewers

SWGEMU-444 6 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

veckon says:

Loshult says:

Loshult says:

Create Issue

Log time against