SWGEMU-422 Fixes for Force Choke.

Fixes for Force Choke.

Details
Objectives
Summary
General Comments 3 (0)

Force_Choke_Fix2.diff (6 months ago) 0 (0)
- bin/scripts/commands 0 (0)
  - forceChoke.lua 0 (0) x
- src/server/zone/objects 0 (0)
  - creature/commands 0 (0)
    - ForceChokeCommand.h 1 (0) x
  - player/events 0 (0)
    - ForceChokeTickTask.h 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Valkyra	Author	20m	3	Please close this review, I am going to make an updated r...
TheAnswer	Moderator	0m
Itac	Reviewer - 0% complete
Loshult	Reviewer - 100% complete	3m	1	Can you please update this patch and fix the issues you n...
cRush	Reviewer - 0% complete
dannuic	Reviewer - 0% complete
oru	Reviewer - 0% complete
Kyle	Reviewer - 0% complete
Total		23m	4

Files: 3
Patches:
- Force_Choke_Fix.diff: (anchored to : / )
- Force_Choke_Fix2.diff: (anchored to swgemu : core3/branches/unstable/MMOCoreORB/ )

#permalink

Objectives

[fixed] Force Choke dot being used by NPC caster.
[fixed] Force Choke stacking.
[updated] Lowered force choke max damage.

#permalink

Summary

Closed review per Valkyra's request.

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

01 Feb

Loshult says:

Can you please update this patch and fix the issues you noted down?

#permalink

01 Feb

Valkyra says:

Will do.

#permalink

03 Feb

Valkyra says:

Please close this review, I am going to make an updated review shortly with the fixed issues.

#permalink

/bin/scripts/commands/forceChoke.lua Changed #permalink
Click to load diff

/src/server/.../commands/ForceChokeCommand.h Changed 1 (0) #permalink
Click to load diff

/src/server/.../events/ForceChokeTickTask.h Changed #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SWGEmu SWGEMU-422

Fixes for Force Choke.

Closed on 03 Feb

Author

Moderator

Reviewers

SWGEMU-422 4 (0)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Valkyra says:

Valkyra says:

Create Issue

Log time against

Current Project

SWGEmu SWGEMU-422

Fixes for Force Choke.

Closed on 03 Feb

Author

Moderator

Reviewers

SWGEMU-422 4 (0)

Summarize the review outcomes (optional)

Details

Objectives

Summary

Issues Raised From Comments

General Comments

Loshult says:

Valkyra says:

Valkyra says:

Create Issue

Log time against